On Tue, 2015-04-21 at 20:14 +0200, Manuel López-Ibáñez wrote: > On 21/04/15 18:07, David Malcolm wrote: > > > > I have the patch working now for the C++ frontend. Am attaching the > > work-in-progress (sans ChangeLog). This one (v2) bootstrapped and > > regrtested on x86_64-unknown-linux-gnu (Fedora 20), with: > > 63 new "PASS" results in gcc.sum > > 189 new "PASS" results in g++.sum > > for the new test cases (relative to a control build of r222248). > > > > I still do not understand why you need so much complexity as I explained > here: > https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00830.html > > The attached patch passes all your tests except Wmisleading-indentation-3.c, > which warns only once instead of two times (it doesn't seem a big loss to > me), > and Wmisleading-indentation-7.c which I did not bother to implement but it is > straightforward application of the if-case to the else-case.
Aha! Thanks. Your approach is much simpler, and likely much faster. > Perhaps I'm missing something that is not reflected in your tests? No, mostly just my lack of expertise on the frontend :) > BTW, the start-up cost of GCC is not negligible, thus grouping similar > testcases in a single file may pay off in the long term. Many small files > also > tend to slow down VC tools. It also makes harder to see what is tested and > what > is missing. OK. I'll finish up your version of the patch, and consolidate the testcases. Thanks Dave
