On 04/17/2015 01:59 AM, Jakub Jelinek wrote:
Hi!
I'd like to ping
PR target/65689 - P2 - http://gcc.gnu.org/ml/gcc-patches/2015-04/msg00358.html
patch (perhaps with the code[?] == ' ' -> ISSPACE (code[?]) changes or
strstr, as discussed in the following thread).
At this point of course for trunk only, and perhaps after a while for 5.2.
For the comment in compute_maybe_allows, "This should be conservative"
could be interpreted as setting both bits or setting neither bit. The
code clearly does the former and with the background from reading the
patch thread I know why, but someone reading the code may not get it
without having to either look in the archives or follow how it gets
used. Consider updating the comment.
I'd tend to prefer strstr; I don't think this is performance sensitive code.
OK for the trunk with the comment fixed and your call on how to handle
the whitespace issues.
jeff
