Hi Martin, On 24 Mar 2015, at 02:50, Martin Sebor wrote:
> On 03/21/2015 01:48 PM, Iain Sandoe wrote: >>>>> 2015-03-13 Anton Blanchard <an...@samba.org> >>>>> >>>>> PR target/63354 >>>>> * gcc/config/rs6000/linux64.h (ARGET_KEEP_LEAF_WHEN_PROFILED): Define. >>>> ^ typo > > It's fixed in version 2 of the patch posted here: > https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00793.html Well, I think I have the new version applied, but slip-ups are possible... >> This ^ will cause a bootstrap fail for every rs6000 target that doesn't >> include linux64.h. >> (because rs6000_keep_leaf_when_profiled will be "defined but unused"). >> >> Since ISTM you intend this to apply to all rs6000 sub-targets, you might as >> well move it to rs6000.h? > > The powerpc-darwin9 and powerpc64-darwin9 targets both built > successfully with this patch. I'm assuming that you mean a cross-compile (which is a stage1 without -werror). If you look in the build output (I just repeated this on x86_64-darwin12 X powerpc-darwin9) you'll see: /GCC/gcc-trunk/gcc/config/rs6000/rs6000.c:24404:1: warning: ‘bool rs6000_keep_leaf_when_profiled()’ defined but not used [-Wunused-function] rs6000_keep_leaf_when_profiled (void) ^ this becomes a bootstrap error at stage#2. If you don't see that, then I have don't have the same patch applied as you :). > I also tried powerpc64-freebsd, > which succeeded as well (though I had to work around pr65535). > What target do you suggest I try to reproduce the failure? > (I don't mind moving the macro definition as you suggest, > but I'd like to understand how to trigger the problem so > that I can reproduce it and verify that I've fixed it.) Any target that doesn't include linux64.h would be a reproducer (AIX, powerpc-linux-gnu). cheers, Iain
