Dear Andre, This patch fixes the issues I have reported in my previous mail. In addition it allows the Metcalf’s oo.f90 to compiles and gives sensible results at run time (yes, I have noticed the patch to fix the memory leak, and it works).
I have a two comments: The list of the (partially) fixed PRs should appear in the Changelog (IIRC no gcc before fortran). I think the English in the comments should be checked. Although I can probably fix the most obvious offenders, English is not my mother language and I have been a terrible pupil (in the E- range) when I was supposed to learn the grammar! Thanks for working on these issues. Cheers, Dominique > Le 19 mars 2015 à 14:03, Andre Vehreschild <ve...@gmx.de> a écrit : > > Hi Dominique, Hi all, > > please find attached a new version of the patch to fix pr64787 after > processing > Dominique's comments. Thank you very much for your work, Dominique. > > The patch now also fixes: > pr63230 - allocation of deferred length character as derived type component > causes internal compiler error > pr51550 - ICE in gfc_get_derived_type, at fortran/trans-types.c:2401 (I > believe > the fortran code in the pr is not legal and fixed it; the fixed one now runs.) > > It partially fixes: > pr55901 - [OOP] type is (character(len=*)) misinterpreted as array > (The codes compile and run, but valgrind reports accesses to uninitialized > memory; I am looking into this.) > pr54070 - [4.8/4.9/5 Regression] Wrong code with allocatable deferred-length > (array) function results > (Compiles again (didn't with the first version of the patch for 64787), but > still segfaults at runtime; -> agenda) > > This patch needs my previous patches as stated in: > https://gcc.gnu.org/ml/fortran/2015-03/msg00076.html > > Bootstraps and regtests ok on x86_64-linux-gnu/F20. > > Reviews and comments welcome. > > Regards, > Andre > -- > Andre Vehreschild * Email: vehre ad gmx dot de
