On 19/03/15 21:50 +0100, François Dumont wrote:
On 18/03/2015 19:16, Jonathan Wakely wrote:
Preparing this patch reminded me that we currently have two copies of
the Catalog_info and Catalogs code in the unnamed namespace in
config/locale/gnu/messages_members.cc, one using the old string and
one using the new. We should really alter the code to not use
std::string so that the catalogs can be shared by both versions of the
messages facets.
Hello
Do you mean like the attached patch ? Or do I need to isolate
get_catalogs function in a dedicated source file that won't be built
twice ?
That's a partial fix, but the types and functions are still in an
anonymous namespace, so will still be duplicated.
To do it correctly they can't be in an anon namespace and the names
must be uglified.
