On Wed, Mar 18, 2015 at 2:24 PM, Martin Liška <mli...@suse.cz> wrote:
> Hello.
>
> Following patch wraps symtab_node::{asm_}name with xstrdup_for_dump.
>
> Ready for trunk?

   /* Gets symbol name of the item.  */
   const char *name (void)
   {
-    return node->name ();
+    return xstrdup_for_dump (node->name ());

shouldn't the methods be called dump_name () then?  And why's
node->name () not already dup-ing the string?

That said, I wonder where we use ->name / ->asm_name.  And why
that's different for ICF.

The patch would be more obvious if all fixes were to dumping sites.

Richard.

> Thanks,
> Martin

Reply via email to