On 12-03-15 10:57, Uros Bizjak wrote:
On Thu, Mar 12, 2015 at 9:11 AM, Tom de Vries <tom_devr...@mentor.com> wrote:

Attached patch adds nonpic target requirement for some (obvious)
cases, where data access or PIC register setup confuses scan-asms.

2015-01-30  Uros Bizjak  <ubiz...@gmail.com>

      * gcc.target/i386/fuse-caller-save-rec.c: Require nonpic target.
      * gcc.target/i386/fuse-caller-save-xmm.c: Ditto.
      * gcc.target/i386/fuse-caller-save.c: Ditto.


Hi,

I've reverted this part of the patch. The scans were failing because the
-fipa-ra optimization was broken for -m32 -fpic (PR64895).

Not really.

Allocator is free to allocate %ebx (or other call-saved
register) as PIC register.

In this case, unwanted push/pop sequence
will be emitted.


Sure, but I don't see what that has to do with the test-cases. I don't see a pic register used in fuse-caller-save.c and fuse-caller-save-rec.c. I do see a pic register used in gcc.target/i386/fuse-caller-save-xmm.c, but there's no scan for push/pop sequence in there.

Thanks,
- Tom

Reply via email to