On Mon, Mar 2, 2015 at 4:37 PM, Bill Schmidt
<wschm...@linux.vnet.ibm.com> wrote:
> Hi,
>
> On Thu, 2015-02-26 at 16:48 -0600, Bill Schmidt wrote:
>>
>> Except this didn't pass regression testing. I'll continue to poke at
>> it.
>
> I figured out the issue here. My handling of the
> TARGET_ALLOW_MOVMISALIGN and TARGET_EFFICIENT_UNALIGNED_VSX macros was
> correct, but there was another problem in the testsuite library
> settings. There was a setting that automatically added the
> -mno-allow-movmisalign option when a test checked for POWER8 vector
> hardware. This is not desirable with the rest of the changes in this
> patch. Removing that was sufficient to get the same test results as
> before.
>
> Here's the revised patch. Everything is the same as before except for
> the first chunk in rs6000.c and the last chunk in target-supports.exp.
> Is this version OK for trunk after GCC 5 branches?
>
> Thanks,
> Bill
>
>
> [gcc]
>
> 2015-03-02 Bill Schmidt <wschm...@linux.vnet.ibm.com>
>
> * config/rs6000/rs6000.c (rs6000_option_override_internal): For
> VSX + POWER8, enable TARGET_ALLOW_MOVMISALIGN and
> TARGET_EFFICIENT_UNALIGNED_VSX if not selected by command line
> option. However, for -mno-allow-movmisalign, be sure to disable
> TARGET_EFFICIENT_UNALIGNED_VSX to avoid an ICE.
> (rs6000_builtin_mask_for_load): Return 0 for targets with
> efficient unaligned VSX accesses so that the vectorizer will use
> direct unaligned loads.
> (rs6000_builtin_support_vector_misalignment): Always return true
> for targets with efficient unaligned VSX accesses.
> (rs6000_builtin_vectorization_cost): Cost of unaligned loads and
> stores on targets with efficient unaligned VSX accesses is almost
> always the same as the cost of an aligned load or store, so model
> it that way.
> * config/rs6000/rs6000.opt (mefficient-unaligned-vector): New
> undocumented option.
>
> [gcc/testsuite]
>
> 2015-03-02 Bill Schmidt <wschm...@linux.vnet.ibm.com>
>
> * gcc.dg/vect/bb-slp-24.c: Exclude test for POWER8.
> * gcc.dg/vect/bb-slp-25.c: Likewise.
> * gcc.dg/vect/bb-slp-29.c: Likewise.
> * gcc.dg/vect/bb-slp-32.c: Replace vect_no_align with
> vect_no_align && { ! vect_hw_misalign }.
> * gcc.dg/vect/bb-slp-9.c: Likewise.
> * gcc.dg/vect/costmodel/ppc/costmodel-slp-33.c: Exclude test for
> vect_hw_misalign.
> * gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c: Likewise.
> * gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c: Adjust tests to
> account for POWER8, where peeling for alignment is not needed.
> * gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c: Replace
> vect_no_align with vect_no_align && { ! vect_hw_misalign }.
> * gcc.dg.vect.if-cvt-stores-vect-ifcvt-18.c: Likewise.
> * gcc.dg/vect/no-scevccp-outer-6-global.c: Likewise.
> * gcc.dg/vect/no-scevccp-outer-6.c: Likewise.
> * gcc.dg/vect/no-vfa-vect-43.c: Likewise.
> * gcc.dg/vect/no-vfa-vect-57.c: Likewise.
> * gcc.dg/vect/no-vfa-vect-61.c: Likewise.
> * gcc.dg/vect/no-vfa-vect-depend-1.c: Likewise.
> * gcc.dg/vect/no-vfa-vect-depend-2.c: Likewise.
> * gcc.dg/vect/no-vfa-vect-depend-3.c: Likewise.
> * gcc.dg/vect/pr16105.c: Likewise.
> * gcc.dg/vect/pr20122.c: Likewise.
> * gcc.dg/vect/pr33804.c: Likewise.
> * gcc.dg/vect/pr33953.c: Likewise.
> * gcc.dg/vect/pr56787.c: Likewise.
> * gcc.dg/vect/pr58508.c: Likewise.
> * gcc.dg/vect/slp-25.c: Likewise.
> * gcc.dg/vect/vect-105-bit-array.c: Likewise.
> * gcc.dg/vect/vect-105.c: Likewise.
> * gcc.dg/vect/vect-27.c: Likewise.
> * gcc.dg/vect/vect-29.c: Likewise.
> * gcc.dg/vect/vect-33.c: Exclude unaligned access test for
> POWER8.
> * gcc.dg/vect/vect-42.c: Replace vect_no_align with vect_no_align
> && { ! vect_hw_misalign }.
> * gcc.dg/vect/vect-44.c: Likewise.
> * gcc.dg/vect/vect-48.c: Likewise.
> * gcc.dg/vect/vect-50.c: Likewise.
> * gcc.dg/vect/vect-52.c: Likewise.
> * gcc.dg/vect/vect-56.c: Likewise.
> * gcc.dg/vect/vect-60.c: Likewise.
> * gcc.dg/vect/vect-72.c: Likewise.
> * gcc.dg/vect/vect-75-big-array.c: Likewise.
> * gcc.dg/vect/vect-75.c: Likewise.
> * gcc.dg/vect/vect-77-alignchecks.c: Likewise.
> * gcc.dg/vect/vect-77-global.c: Likewise.
> * gcc.dg/vect/vect-78-alignchecks.c: Likewise.
> * gcc.dg/vect/vect-78-global.c: Likewise.
> * gcc.dg/vect/vect-93.c: Likewise.
> * gcc.dg/vect/vect-95.c: Likewise.
> * gcc.dg/vect/vect-96.c: Likewise.
> * gcc.dg/vect/vect-cond-1.c: Likewise.
> * gcc.dg/vect/vect-cond-3.c: Likewise.
> * gcc.dg/vect/vect-cond-4.c: Likewise.
> * gcc.dg/vect/vect-cselim-1.c: Likewise.
> * gcc.dg/vect/vect-multitypes-1.c: Likewise.
> * gcc.dg/vect/vect-multitypes-3.c: Likewise.
> * gcc.dg/vect/vect-multitypes-4.c: Likewise.
> * gcc.dg/vect/vect-multitypes-6.c: Likewise.
> * gcc.dg/vect/vect-nest-cycle-1.c: Likewise.
> * gcc.dg/vect/vect-nest-cycle-2.c: Likewise.
> * gcc.dg/vect/vect-outer-3a-big-array.c: Likewise.
> * gcc.dg/vect/vect-outer-3a.c: Likewise.
> * gcc.dg/vect/vect-outer-5.c: Likewise.
> * gcc.dg/vect/vect-outer-fir-big-array.c: Likewise.
> * gcc.dg/vect/vect-outer-fir-lb-big-array.c: Likewise.
> * gcc.dg/vect/vect-outer-fir-lb.c: Likewise.
> * gcc.dg/vect/vect-outer-fir.c: Likewise.
> * gcc.dg/vect/vect-peel-3.c: Likewise.
> * gcc.dg/vect/vect-peel-4.c: Likewise.
> * gcc.dg/vect/vect-pre-interact.c: Likewise.
> * gcc.target/powerpc/vsx-vectorize-2.c: Exclude test for POWER8.
> * gcc.target/powerpc/vsx-vectorize-4.c: Likewise.
> * gcc.target/powerpc/vsx-vectorize-6.c: Likewise.
> * gcc.target/powerpc/vsx-vectorize-7.c: Likewise.
> * gfortran.dg/vect/vect-2.f90: Replace vect_no_align with
> vect_no_align && { ! vect_hw_misalign }.
> * gfortran.dg/vect/vect-3.f90: Likewise.
> * gfortran.dg/vect/vect-4.f90: Likewise.
> * gfortran.dg/vect/vect-5.f90: Likewise.
> * lib/target-supports.exp (check_effective_target_vect_no_align):
> Return 1 for POWER8.
> (check_effective_target_vect_hw_misalign): Return 1 for POWER8.
> (check_vect_support_and_set_flags): Don't set
> -mno-allow-movmisalign for POWER8 vector hardware.
Okay.
Thanks, David
