On Thu, 19 Feb 2015, Jakub Jelinek wrote: > On Thu, Feb 19, 2015 at 01:41:05PM +0100, Richard Biener wrote: > > I hope we can get rid of this again (which needs re-writing of all > > targets va-arg gimplification hooks... - we are in need of some > > generic diamond/triangle CFG pattern builders anyway). > > We already have some in asan.c - create_cond_insert_point - perhaps > it isn't best named and could use some changes to be generally usable.
Yeah - we should look at individual uses to see what is needed. I guess some are to generate a COND_EXPR with arms that can have side-effects, thus produce a single value in two different ways dependent on a condition. Others are to just guard a code region. Richard.
