Hi David, Am 2015-02-14 um 22:05 schrieb David Edelsohn: > Hi, Michael > > Thanks for noticing this. This patch generally seems to be on the > right track. The original ASM_OUTPUT_EXTERNAL code was not completely > correct in the pedantic sense. It should use [UA] mapping class > instead of [RW] for all non-function descriptor symbols.
One more thought: How is that dollar_inside thing seen in ASM_OUTPUT_EXTERNAL supposed to work/be used? > This patch also needs a dg-final scan-assembler test to check for [DS] > and [UA] to ensure that this does not regress again in the future. Thanks for committing! /haubi/ (the one you gave commit access already:)
