Jeff Law <l...@redhat.com> writes:
>> Subject: [PATCH 1/5] Add check_effective_target_pie
>>
>> Hi,
>>
>> This patch adds check_effective_target_pie to check if the current
>> multilib generates PIE by default.
>>
>> Thanks.
>>
>> H.J.
>> ---
>> 2015-01-11 H.J. Lu <hongjiu...@intel.com>
>>
>> * gcc.target/i386/pie.c: New test.
>>
>> * lib/target-supports.exp (check_effective_target_pie): New.
> OK.
The new proc is bogus, unfortunately: there's already an existing
check_effective_target_pie that checks if a target can support PIE. The
new one just overrides the previous one. On targets supporting PIE
(like Darwin), but not defaulting to it, the PIE tests suddenly turn out
UNSUPPORTED.
You should rename the new one to
e.g. check_effective_target_pie_default, update the single user, and
document it in sourcebuild.texi.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
