On Tue, Feb 10, 2015 at 04:56:40PM +0100, Martin Liška wrote:
> On 02/10/2015 01:50 PM, Richard Biener wrote:
> >On Tue, Feb 10, 2015 at 12:07 PM, Martin Liška <mli...@suse.cz> wrote:
> >>Hello.
> >>
> >>Following patch is fix for PR ipa/64813. The patch was tested on a darwin
> >>target
> >>by Dominique.
> >>
> >>Ready for trunk?
> >
> >- if (!(gimple_call_flags (call) & ECF_NORETURN))
> >+ if (!alias_is_noreturn)
> >
> >that was technically unnecessary, right? The call flags properly
> >return ECF_NORETURN already?
> >
> >Ok if that is the case.
>
> Hi.
>
> You are right, !(gimple_call_flags (call) & ECF_NORETURN) returns a correct
> value.
> Motivation for replacement is not to repeat the same condition, I hope the
> value
> of alias_is_noreturn is correct in all uses.
And gimple_call_flags (call) & ECF_NORETURN doesn't? I mean, if you could
initialize alias_is_noreturn to that, it would be nicer.
Jakub
