On 02/02/15 15:34, Szabolcs Nagy wrote: > > > On 30/01/15 19:14, Richard Henderson wrote: >> On 01/30/2015 04:52 AM, Szabolcs Nagy wrote: >>> When running natively on AArch64 the preprocessor did not use the >>> AdvSIMD optimized search_line_fast function, because it was ifdefed >>> around by __ARM_NEON__ instead of __ARM_NEON. >> >> Yes, sorry I didn't follow up on that from September: >> >> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00149.html >> >> You also want to change to use vaddvq_u16 instead of >> the current vpadd and vget_lane reduction. >> >> I was going to wait until stage1 to resubmit this. >> > > > that's a bigger change, can it be a separate patch > or do you plan to do it together with the ifdef fix? > > >
I think the two should be separated. The existing code will work on AArch64, even though it could be improved upon. R.
