On 1/28/15 20:02, Andrew Burgess wrote: > * Chen Gang S <gang.c...@sunrus.com.cn> [2015-01-28 19:34:38 +0800]: > >> libiberty/argv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libiberty/argv.c b/libiberty/argv.c >> index f2727e8..9fdd55b 100644 >> --- a/libiberty/argv.c >> +++ b/libiberty/argv.c >> @@ -454,7 +454,7 @@ expandargv (int *argcp, char ***argvp) >> /* Free up memory allocated to process the response file. We do >> not use freeargv because the individual options in FILE_ARGV >> are now in the main ARGV. */ >> - free (file_argv); >> + freeargv (file_argv); > > I'm not commenting on the correctness of the patch, however, you will > need to update the comment just above this change. > > Personally, I'd also hope that the commit message explains why the > comment is no longer correct, rather than just stating that the change > has been made. >
Oh, really. Excuse me, originally I did not notice about it. I shall send patch v2 for it (just like what DJ Delorie said in another reply). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed
