On Sat, Jan 17, 2015 at 10:34 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Sat, Jan 17, 2015 at 12:19 AM, Ian Lance Taylor <i...@golang.org> wrote: > >>> You should also revert alpha specific change to >>> libgo/go/testing/quick/quick_test.go, please see [1] and [2]. >>> >>> [1] https://gcc.gnu.org/ml/gcc-patches/2013-03/msg00038.html >>> [2] https://gcc.gnu.org/ml/gcc-patches/2013-03/msg00038/foo.patch >> >> Done like so. Committed to mainline. > > Thanks! > > There is another part in runtime/go-ffi.c that looks like it is not > necessary anymore with FFI_TARGET_HAS_COMPLEX_TYPE. > > Attached proto-patch that removes special Complex64 handling survives > go regression test for i686 target. However, some of i686 targets > don't define FFI_TARGET_HAS_COMPLEX_TYPE, so at least this part should > be conditional on !ifndef FFI_TARGET_HAS_COMPLEX_TYPE.
Thanks. Committed based on Richard H's later comments. Ian