On Thu, Jan 15, 2015 at 7:35 PM, Jeff Law <l...@redhat.com> wrote: > On 11/20/14 05:33, Bernd Schmidt wrote: >> >> Now that I've managed to put together and test all the submitted OpenACC >> patches I found there was one piece missing. The problem is that omp-low >> on the host likes to generate function names like "_main._omp_fn". On >> ptx, the dot is not allowed in identifiers, so we have to rewrite this >> to use a dollar sign. >> >> The patch below does this at the lto-read stage. Bootstrapped on >> x86_64-linux, ok if testing is successful? > > Was expecting Richi or Honza to review this... They certainly know the LTO > bits far better than I. Or have you ultimately addressed this issue some > other way?
I don't like the validize_symbol_for_target thing - you create proper symbols elsewhere from the start - what's left to fix? IMHO we should have a single helper somewhere for concatenating with some separator. Richard. > jeff >
