On Thu, Jan 15, 2015 at 9:45 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Thu, Jan 15, 2015 at 01:58:43PM +0100, Richard Biener wrote: >> [ 5286s] ../../../libgo/go/reflect/makefuncgo_s390x.go:323:5: error: >> expected '; >> ' or '}' or newline >> [ 5286s] } else { >> [ 5286s] ^ > > Bet that > } else { > line should have been replaced with > default:
Indeed. I committed that patch, and actually tested that the file at least compiled. Committed to mainline. Ian
diff -r a8a14eba5197 libgo/go/reflect/makefuncgo_s390x.go --- a/libgo/go/reflect/makefuncgo_s390x.go Wed Jan 14 16:52:08 2015 -0800 +++ b/libgo/go/reflect/makefuncgo_s390x.go Thu Jan 15 12:41:04 2015 -0800 @@ -320,7 +320,7 @@ switch v.Kind() { case Ptr, UnsafePointer, Chan, Func, Map: w = uintptr(v.pointer()) - } else { + default: memmove(unsafe.Pointer(&w), v.ptr, v.typ.size) if ret_off_reg != 0 { w = s390xReloadForRegister(