On 07/09/2011 06:42 PM, H.J. Lu wrote: > On Sat, Jul 9, 2011 at 6:34 PM, Richard Henderson <r...@redhat.com> wrote: >> I developed this patch while working on the dwarf2 pass series. >> This was before I bypassed the entire problem by removing the >> !deep branch prediction paths. >> >> Ideally, we'd do this generically from gimple. Less ideally, >> but still better, is to always emit rtl, and support that in >> the middle end without so many hacks in the back end. >> >> I think this cleans things up a bit over emitting text. >> Particularly if we then include HJ's x32 stuff. >> >> Thoughts? > > For TARGET_64BIT, please use ptr_mode instead of DImode > to load thunk into a register.
That's not quite good enough. For Correctness you need a zero-extension into Pmode. r~
