On Tue, Jan 06, 2015 at 01:04:29PM +0100, Eric Botcazou wrote:
> > I normally build with --disable-libsanitizer, because the sanitizers
> > testresults are very unreproducable, so just annoying noise. This however
> > makes most (all?) ubsan testcases fail, since they want to load a shared
> > library that does not exist.
>
> Same here, but I also have the problem with tsan testcases.
>
> > gcc/testsuite/
> > * lib/ubsan-dg.exp (check_effective_target_fsanitize_undefined):
> > Check if testcases run without errors, not just if they compile.
>
> I additionally need:
>
> * lib/tsan-dg.exp (check_effective_target_fsanitize_thread):
> Check if testcases run without errors, not just if they compile.
What errors do you get? Just curious. That said, I think your patch is fine.
> --- lib/tsan-dg.exp (revision 219217)
> +++ lib/tsan-dg.exp (working copy)
> @@ -18,7 +18,7 @@
> # code, 0 otherwise.
>
> proc check_effective_target_fsanitize_thread {} {
> - return [check_no_compiler_messages fsanitize_thread executable {
> + return [check_runtime fsanitize_thread {
> int main (void) { return 0; }
> } "-fsanitize=thread"]
> }
Jakub
