On Thu, Jul 07, 2011 at 09:52:31PM +0200, Eric Botcazou wrote:
> OK, modulo a few nits:
> 
> +  /* If address come in register - we have no idea of its origin, so
> +     give up and conservatively return true */
> +  else if (GET_CODE (addr) == REG)
> 
> /* If the address comes in a register, we have no idea of its origin so
>    give up and conservatively return true.  */
> 
> Note the period-double-space-star-slash GNUism at the end.  Non-negotiable.

Also, please use REG_P (addr) instead of GET_CODE (addr) == REG.

        Jakub

Reply via email to