Hi Nicola,
On 2 Jul 2011, at 19:06, Nicola Pero wrote:
This patch improves the modularity of the Objective-C Front-End by
separating
out the encoding code into separate objc-encoding.h and objc-
encoding.c files.
thanks for doing this .. :-)
The performance impact of this patch should be minimal; there a few,
well-defined
entry points to the encoding machinery (such as calls to encode a
method prototype, or
an instance variable, or to produce an @encode string) and they were
already standard
functions; having them in one compilation unit or the other doesn't
change anything. All
the other encoding functions just call each other, and are static,
so again moving them to
a different unit has no performance impact.
I suspect that having a more modular code base will bring its own
improvements, since it becomes easier to focus on and see the scope of
optimizations.
In any event, as we move towards bootstrapping with lto, these issues
should vanish as a concern.
as a datum, the patch works for me on *-darwin9 ...
cheers
Iain
