On Fri, Jun 24, 2011 at 19:13, Gabriel Charette <gch...@google.com> wrote: > We were only streaming the first field of every struct. Struct fields have a > chain link to the next field, thus we need to stream the DECL_CHAIN of every > field as well recursively. > > I limited this to VAR_DECL and FUNCTION_DECL for now (which fixes all of our > current bugs in regards to the struct fields issues), are there any other > DECLs that can potentially be fields of a struct?
FIELD_DECLs are the natural members of structs. But those are handled by generic streaming. Also needed for PARM_DECLs (already handled as well). VAR_DECLs and FUNCTION_DECLs were the only ones missing. > Syntax-wise: Is it ok to play this 'case' fall through trick with VAR_DECL or > should I make a > separate case entry with it's own break? Cleaner to just distinguish them inside the main group. I've tweaked it and committed to the branch. We are still missing some link attributes. The code compiles but does not link. I will look into that today. Diego.
