On Sat, 25 Jun 2011, H.J. Lu wrote:

> +#ifndef UNIQUE_UNWIND_CONTEXT

The use of #ifndef seems to imply that this is a target macro, to be 
defined in libgcc_tm.h.  In that case it should be documented, and 
poisoned in system.h under the "only used for code built for the target" 
case, and this:

> +#if defined __x86_64 && !defined __LP64__

is inappropriate since you should instead put it in an appropriate header 
in libgcc/config/, rather than hardcoding an architecture-specific #if in 
an architecture-independent file.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to