-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/22/11 08:25, Bernd Schmidt wrote: > On 06/14/2011 05:32 PM, Jeff Law wrote: >> >> This version incorporates suggestions from Bernd. Basically we have >> reload1.c set reload_completed internally rather than deferring it into >> ira.c. That allows the call to reload() to return whether or not a DCE >> pass is desirable at the end of reload. >> >> That in turn allows us to avoid the DF clumsiness of the previous version. >> >> Bootstrapped and regression tested on x86_64-unknown-linux-gnu. > > This is OK, although I'm slightly confused - wasn't your original > problem caused by the other delete_dead_insn call? It was caused by the recursive nature of delete_dead_insn. Removing the equivalencing insn is OK, it's deleting the insns feeding the equivalencing insn that causes problems.
We could have delete_dead_insn not remove the equivalencing insn, but that's going to trigger a lot more calls to DCE after reload has completed and thus a higher compile-time hit. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOA6ZwAAoJEBRtltQi2kC7U50H/AlscEfPiXJr3m89IEMp/eO3 C7NNc6WRaUPc/6j7T36xlryJd9H01VBKtuVDNHMAutWfosVhqufEid6a94okLbFG IWsd2Bd1UTiqt9l0ddklo3/9XYmQoKlYmoYi+5XrvjGi+RQAByThA1j2agehMri7 ENxaYuvsAiitdl7Uan5hkTCcM0u4oLU1xBTbDa37o0Z0XDwVl3m4t47cwIQxpvWD HZD5VvvafgvLRsmtRdJ8lipujicNR1uV2eblF08ZBnf8gat4AQ7/0+SLKLrLN1bN 9RIB7YJHgm2yxTnZ0pms1+elkTMvqVKhy+Mvk8u7njsRGpixgavhhlFfbtKvVeo= =K8kI -----END PGP SIGNATURE-----