http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right):
http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer-in.c#newcode1003 gcc/cp/pph-streamer-in.c:1003: namespace. 1001 /* FIXME pph: this carried over from pph_add_names_to_namespace, 1002 » it only makes sense to use this when merging names in an existing 1003 » namespace. pph_add_names_to_namespace does not exist anymore. I don't understand this comment. http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer-out.c File gcc/cp/pph-streamer-out.c (right): http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer-out.c#newcode947 gcc/cp/pph-streamer-out.c:947: gcc_assert ( ss->old_namespace == global_namespace 945 /* old_namespace should be global_namespace and all entries listed below 946 should be NULL or 0; otherwise the header parsed was incomplete. */ 947 gcc_assert ( ss->old_namespace == global_namespace No space after '('. http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer-out.c#newcode949 gcc/cp/pph-streamer-out.c:949: || ss->function_decl || ss->template_parms || ss->x_saved_tree 948 && !(ss->class_name || ss->class_type || ss->access_specifier 949 || ss->function_decl || ss->template_parms || ss->x_saved_tree Align '&&' vertically with the open brace. http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer.c File gcc/cp/pph-streamer.c (right): http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer.c#newcode34 gcc/cp/pph-streamer.c:34: #include "name-lookup.h" 33 #include "cppbuiltin.h" + 34 #include "name-lookup.h" You also need to add cp/name-lookup.h to the list of dependencies for cp/pph.o in cp/Make-lang.in. http://codereview.appspot.com/4661045/
