I am on travel and only doing email from my phone. Ralf and I had dinner together last night and he mentioned not understanding some parts of the patch. I won't be home until next week to actually test this.
I guess hoping due diligence was used and knowing I may whine next week if it breaks RTEMS, do a visual double check please on the RTEMS specific parts and commit it. Either that or wait for a test report from me. --joel Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote: >Paolo Bonzini <bonz...@gnu.org> writes: > >> On 05/30/2011 04:29 PM, Rainer Orth wrote: >>>>> * Non-Solaris SPARC changes: >>>>> >> >>>>> >> After I had moved sparc/sol2-c[in].asm to libgcc, I noticed that >>>>> >> despite the name a few non-Solaris targets uses those files, too: >>>>> >> >>>>> >> sparc-*-elf*, sparc-*-rtems*, sparc64-*-elf*, sparc64-*-rtems* >>>> > >>>> > Yes, I tried to untangle that, but the RTEMS folks complained so I had >>>> > to >>>> > backpedal. Note that this is also the case on the i386 side. >>> Drats, I hadn't expected anything like this ;-( >>> >>> Here's the updated patch which takes care of this. I've taken the >>> liberty to rename gcc/config/i386/t-rtems-i386 to >>> gcc/config/i386/t-rtems, following all other RTEMS makefile fragments. >>> I'd be really grateful if the RTEMS maintainers could give it a whirl. >>> >>> Besides, I still need build and SPARC maintainer approval for the >>> non-Solaris parts of the patch from as outlined in the previous >>> submission: >>> >>> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02181.html >>> >>> Bootstrapped without regressions on i386-pc-solaris2.10, >>> i386-pc-solaris2.11 and sparc-sun-solaris2.11. >>> >>> Ok for mainline after the RTEMS parts have been tested/approved? >> >> Looks good as far as I'm concerned. As a followup, please delete >> t-slibgcc-darwin and use the new t-slibgcc-dummy instead (even better, you >> could "svn mv" it). > >I think I just need RTEMS testing/approval now, everything else should >be set? > > Rainer > >-- >----------------------------------------------------------------------------- >Rainer Orth, Center for Biotechnology, Bielefeld University
