On Fri, 20 May 2011 11:47:57 +0200 Pierre Vittet <pier...@pvittet.com> wrote:
> I have corrected my patch with your remarks. > > Especially about the debug functions, it takes the debug melt flag into > account. Moreover, I have allowed the user to give a message when > calling this function, as usual in MELT debug functions. Giving this > message was a bit difficult (This is the only argument of the function, > so this must be a MELT value, and that uneasy to convert the value into > :cstring). > > I have used debugeprintf macro into a code_chunk to give the MELT file + > line numbers, followed by a outstr_err, which displays the user message. > I think the only disavantage is that it puts an end of lines between the > two informations. If you think there is a best way to do this, I am ok > to try it. Thanks. I've committed Pierre's patch with minor improvements (simplification of debug_dominance_info) discussed by phone. I also changed the spelling of internaly to internally! And I added Pierre's name as a contributor in the copyright notice of xtramelt-ana-base.melt Committed revision 173945. By the way, I am quite happy of Pierre patches to the MELT branch. Is this enough to get him a write access to GCC SVN (all legalese is done)? I fear that to really get that write access, Pierre would also need to have accepted patches to the trunk (i.e. that writing good patches to a branch is not enough)... I still don't understand the criteria to admit Pierre to the Write After Approval list of maintainers with a write access to GCC SVN... Regards -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mine, sont seulement les miennes} ***
