On Mon, May 16, 2011 at 7:41 PM, Zuxy Meng <zuxy.m...@gmail.com> wrote: > 2011/5/16 H.J. Lu <hjl.to...@gmail.com>: >> On Sun, May 15, 2011 at 10:03 PM, Zuxy Meng <zuxy.m...@gmail.com> wrote: >>> Misdetected as Athlon by GCC, K6-2+ and K6-3+ are processors that support >>> extended 3DNow! but don't support extended MMX or CMOV. >>> >>> I don't own a K6-2 or Athlon machine. Can anybody have the patch tested? >>> >>> 2011-05-16 Zuxy Meng <zuxy.m...@gmail.com> >>> PR i386/48743 >>> * config/i386/cpuid.h (bit_MMXEXT): New >>> * config/i386/cpuid.h (bit_3DNOWP): Deleted >> >> Why do you remove bit_3DNOWP? <cpuid.h> is a public header file. > > Because this bit was added to detect Athlon and not used elsewhere.
The first part might be true and the second part is false. Since <cpuid.h> is a public header file, it may be used in any software packages. > cpuid.h doesn't define all the feature bits available in the output of > CPUID instruction so I thought only the actually used bits are to be > included. That is false. I would appreciate a patch to define all feature bits. -- H.J.
