Honza, what do you think of the patch? It actually fixed a regression. Thanks,
David On Wed, May 4, 2011 at 4:40 PM, Xinliang David Li <davi...@google.com> wrote: > Is this patch ok for trunk? > > Allowing relative path in -fprofile-generate= is very useful when > running the program remotely -- the profile data will be just dumped > in the dir relative to the working dir in the remote machine. Using > GCOV_PREFIX_STRIP can workaround the problem, but it is not always to > pass environment around. > > Thanks, > > David > > On Wed, Feb 23, 2011 at 3:37 PM, Martin Thuresson <mart...@google.com> wrote: >> On Wed, Feb 23, 2011 at 10:21 AM, Martin Thuresson <mart...@google.com> >> wrote: >>> Change 165596 and 168475 updated the code for handling gcda-paths. As >>> part of this change, relative paths stopped working. >>> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47793 >>> >>> This patch adds a guard so that "/" is not added when no prefix is >>> given. >>> >>> The added testcase uses the path "../gcc/". This puts the gcda in the >>> same directory, so that the cleanup-coverage-files will find them. >>> >>> I have tested the patch using "make bootstrap; make -k check" with >>> target x86_64-unknown-linux-gnu and saw no additional test failures. >>> >>> Let me know if there is any other testing I should do. >> >> ChangeLog >> gcc/ >> >> 2011-02-23 Martin Thuresson <mart...@google.com> >> >> PR gcov-profile/47793 >> * libgcov.c (gcov_exit): Support relative profile paths. >> >> gcc/testsuite/ >> >> 2011-02-23 Martin Thuresson <mart...@google.com> >> >> PR gcov-profile/47793 >> * gcc.dg/pr47793.c: New. >> >>> >>> Thanks, >>> Martin >>> >> >
