> 2011/4/15 Jan Hubicka <hubi...@ucw.cz>: > >> > > >> > I fixed this on the and added sanity check that the fields are > >> > initialized. > >> > This has shown problem with early inliner iteration fixed thusly and > >> > fact that > >> > early inliner is attempting to compute overall growth at a time the > >> > inline > >> > parameters are not computed for functions not visited by early > >> > optimizations > >> > yet. We previously agreed that early inliner should not try to do that > >> > (as this > >> > leads to early inliner inlining functions called once that should be > >> > deferred > >> > for later consieration). I just hope it won't cause benchmarks to > >> > regress too much ;) > >> > >> Yeah, we agreed to that. And I forgot about it as it wasn't part of the > >> early inliner reorg (which was supposed to be a 1:1 transform). > > > > Today C++ results shows some regressions, but nothing earthshaking. So I > > think it is good > > idea to drop this feature of early inliner since it is not really > > systematic. > > There is also great improvement on LTO SPEC2000, but I tend to hope it is > > unrelated change. > > Perhaps your aliasing? > > I doubt SPEC2k uses VLAs or alloca, does it? Might be the DSE > improvements, but I'm not sure.
It seems to happen only with LTO, so it might be inlining & fixed call cost estimates. It does not seem so likely to me however - I know that gzip is touchy about inlining, but vortex seems easy. Honza
