On 03/31/2011 01:09 PM, Richard Sandiford wrote:
>> I think the assert should be retained (for now) as
>>
>> gcc_assert (nops == 4 || nops == 6);
>>
>> at least until we add such verification to some genfoo.
>
> After the patch we have:
>
> gcc_assert (nops == (unsigned int) insn_data[(int) icode].n_generator_args);
>
> in maybe_gen_insn, which should catch this. Just to check: do you want
> the assertion here anyway?
Well, it won't because we initialized nops *with .n_generator_args.
If nops was initialized with
nops = 4;
create the first 4 args
if (.n_generator_args == 6)
{
nops = 6;
create the last two args
}
then the assert you mention *would* do the trick.
r~
