-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/30/11 10:51, Richard Sandiford wrote: > Nice cleanup thanks. Just noticed a couple of things: > > Jeff Law <l...@redhat.com> writes: >> *************** struct reload >> *** 100,106 **** >> int inc; >> /* A reg for which reload_in is the equivalent. >> If reload_in is a symbol_ref which came from >> ! reg_equiv_constant, then this is the pseudo >> which has that symbol_ref as equivalent. */ >> rtx in_reg; >> rtx out_reg; >> --- 100,106 ---- >> int inc; >> /* A reg for which reload_in is the equivalent. >> If reload_in is a symbol_ref which came from >> ! reg_equiv_consant, then this is the pseudo >> which has that symbol_ref as equivalent. */ >> rtx in_reg; >> rtx out_reg; > > Adds typo. > >> *************** elimination_effects (rtx x, enum machine >> *** 3002,3011 **** >> } >> >> } >> ! else if (reg_renumber[regno] < 0 && reg_equiv_constant >> ! && reg_equiv_constant[regno] >> ! && ! function_invariant_p (reg_equiv_constant[regno])) >> ! elimination_effects (reg_equiv_constant[regno], mem_mode); >> return; >> >> case PRE_INC: >> --- 2996,3006 ---- >> } >> >> } >> ! else if (reg_renumber[regno] < 0 >> ! && reg_equiv_constant (0) >> ! && reg_equiv_constant (regno) >> ! && ! function_invariant_p (reg_equiv_constant (regno))) >> ! elimination_effects (reg_equiv_constant (regno), mem_mode); >> return; >> >> case PRE_INC: > > Looks like this should be s/reg_equiv_constant (0)/reg_equivs != 0/. Bootstrapped & regression tested on x86_64-unknown-linux-gnu. Installed as obvious.
jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNlKPmAAoJEBRtltQi2kC7f1kH/1t6YammyGZdUelSmGgoxLOI dbmzBULytfTvtR3s6reYtqpLxf5h6zGVEQtSNGxdH+59/X79pFYz/zfJcWRgWYBu zuua5tAqZdMzGB8xZOOh81U924Pw16nzC3KwX1Bbj7LJFzr95zu7FOvzahR6ikEi gmsu7liwOu+eEIgYEo9YV1j05XXDwBGsxvJFCuUzH2R6kE9tGafck/E+H5l9+oUw Rlbza01ukFGJHSimOPdO4TDCYmhR8u/FwMtJWO05wKfhBC6xw2ronI7bo2cKgMUM GVMNGncfIisKYVa8rzso7aKBnzcPnmG8E4tJ2wvXe+OsvDe5Nj9XWQrRV8mtOHo= =j7SI -----END PGP SIGNATURE-----
* reload1.c (elimination_effects): Fix typo in recent change. Index: reload1.c =================================================================== *** reload1.c (revision 171787) --- reload1.c (working copy) *************** elimination_effects (rtx x, enum machine *** 2997,3003 **** } else if (reg_renumber[regno] < 0 ! && reg_equiv_constant (0) && reg_equiv_constant (regno) && ! function_invariant_p (reg_equiv_constant (regno))) elimination_effects (reg_equiv_constant (regno), mem_mode); --- 2997,3003 ---- } else if (reg_renumber[regno] < 0 ! && reg_equivs != 0 && reg_equiv_constant (regno) && ! function_invariant_p (reg_equiv_constant (regno))) elimination_effects (reg_equiv_constant (regno), mem_mode);