On 03/23/2011 01:17 PM, Nathan Froyd wrote: > * emit-rtl.c (emit_pattern_after_setloc): New function. > (emit_insn_after_setloc, emit_jump_insn_after_setloc): Call it. > (emit_call_insn_after_setloc, emit_debug_insn_after_setloc): Likewise. > (emit_pattern_after): New function. > (emit_insn_after, emit_jump_insn_after): Call it. > (emit_call_insn_after, emit_debug_insn_after): Likewise. > (emit_pattern_before_setloc): New function. > (emit_insn_before_setloc, emit_jump_insn_before_setloc): Call it. > (emit_call_insn_before_setloc, emit_debug_insn_before_setloc): > Likewise. > (emit_pattern_before): New function. > (emit_insn_before, emit_jump_insn_before): Call it. > (emit_call_insn_before, emit_debug_insn_before): Likewise.
Ok. Please look into removing the "last" parameter from emit_pattern_before_noloc, which would allow removing the "insnp" parameter from emit_pattern_before_setloc. I can't see how emitting a NULL_RTX should be a Good Thing, ever, and thus I don't see why we should be doing special things to handle it. r~
