2011/3/8 Eli Zaretskii <e...@gnu.org>: >> From: Pedro Alves <pe...@codesourcery.com> >> Date: Tue, 8 Mar 2011 13:33:02 +0000 >> Cc: Kai Tietz <ktiet...@googlemail.com>, >> gcc-patches@gcc.gnu.org, >> Eli Zaretskii <e...@gnu.org>, >> binut...@sourceware.org >> >> On Tuesday 08 March 2011 12:48:11, Kai Tietz wrote: >> >> > Well, a better example is elfstab_offset_sections() in elfread.c. >> >> /* The ELF symbol info doesn't include path names, so strip the path >> (if any) from the psymtab filename. */ >> while (0 != (p = strchr (filename, '/'))) >> filename = p + 1; >> >> Looks like its looking for the last path separator, so >> it might as well use filename_dirrchr instead. > > Exactly. > >> > Another is in find_file_and_directory() in dwarf2read.c file. >> >> Workaround for Irix. Certainly that '/' should not depend >> on the host gdb is running on. > > It actually should use IS_ABSOLUTE_FILE_NAME, if any portability > enhancement is needed here. > > In my experience, the strchr analog is not needed, only the strrchr > one (which could be used quite a lot). The few places that use strchr > now should actually be rewritten to search from the end, because > that's what they need. >
Here I am not that sure. For example in gcc's gengtype.c (read_input_list) is a use-case for strchr on filenames, which can't be expressed by strrchr. Please be aware that libiberty is shared between different ventures. I admit that filenames/paths are searched normal from right to left. But there might be cases a left to right search is suitable. Regards, Kai
