https://gcc.gnu.org/g:f3d455ef80e1d81cb5fbdc35152c0062f6922a06
commit f3d455ef80e1d81cb5fbdc35152c0062f6922a06 Author: Michael Meissner <meiss...@linux.ibm.com> Date: Sat Oct 5 22:57:54 2024 -0400 Change TARGET_CMPB to TARGET_POWER6 As part of the architecture flags patches, this patch changes the use of TARGET_FPRND to TARGET_POWER6. The CMPB instruction was added in power6 (ISA 2.05). I have built both big endian and little endian bootstrap compilers and there were no regressions. In addition, I constructed a test case that used every archiecture define (like _ARCH_PWR4, etc.) and I also looked at the .machine directive generated. I ran this test for all supported combinations of -mcpu, big/little endian, and 32/64 bit support. Every single instance generated exactly the same code with the patches installed compared to the compiler before installing the patches. Can I install this patch on the GCC 15 trunk? 2024-10-05 Michael Meissner <meiss...@linux.ibm.com> * config/rs6000/rs6000-builtin.cc (rs6000_builtin_is_supported): Use TARGET_POWER6 instead of TARGET_CMPB. * config/rs6000/rs6000.h (TARGET_FCFID): Merge tests for popcntb, cmpb, and popcntd into a single test for TARGET_POWER5. (TARGET_LFIWAX): Use TARGET_POWER6 instead of TARGET_CMPB. * config/rs6000/rs6000.md (enabled attribute): Likewise. (parity<mode>2_cmp): Likewise. (cmpb): Likewise. (copysign<mode>3): Likewise. (copysign<mode>3_fcpsgn): Likewise. (cmpstrnsi): Likewise. (cmpstrsi): Likewise. Diff: --- gcc/config/rs6000/rs6000-builtin.cc | 4 ++-- gcc/config/rs6000/rs6000.h | 6 ++---- gcc/config/rs6000/rs6000.md | 16 ++++++++-------- 3 files changed, 12 insertions(+), 14 deletions(-) diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc index 98a0545030cd..76421bd1de0b 100644 --- a/gcc/config/rs6000/rs6000-builtin.cc +++ b/gcc/config/rs6000/rs6000-builtin.cc @@ -157,9 +157,9 @@ rs6000_builtin_is_supported (enum rs6000_gen_builtins fncode) case ENB_P5: return TARGET_POWER5; case ENB_P6: - return TARGET_CMPB; + return TARGET_POWER6; case ENB_P6_64: - return TARGET_CMPB && TARGET_POWERPC64; + return TARGET_POWER6 && TARGET_POWERPC64; case ENB_P7: return TARGET_POPCNTD; case ENB_P7_64: diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h index 4500724d895c..d22693eb2bfb 100644 --- a/gcc/config/rs6000/rs6000.h +++ b/gcc/config/rs6000/rs6000.h @@ -448,13 +448,11 @@ extern int rs6000_vector_align[]; Enable 32-bit fcfid's on any of the switches for newer ISA machines. */ #define TARGET_FCFID (TARGET_POWERPC64 \ || TARGET_PPC_GPOPT /* 970/power4 */ \ - || TARGET_POPCNTB /* ISA 2.02 */ \ - || TARGET_CMPB /* ISA 2.05 */ \ - || TARGET_POPCNTD) /* ISA 2.06 */ + || TARGET_POWER5) /* ISA 2.02 and above */ \ #define TARGET_FCTIDZ TARGET_FCFID #define TARGET_STFIWX TARGET_PPC_GFXOPT -#define TARGET_LFIWAX TARGET_CMPB +#define TARGET_LFIWAX TARGET_POWER6 #define TARGET_LFIWZX TARGET_POPCNTD #define TARGET_FCFIDS TARGET_POPCNTD #define TARGET_FCFIDU TARGET_POPCNTD diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md index 7f9fe609a031..0c303087e944 100644 --- a/gcc/config/rs6000/rs6000.md +++ b/gcc/config/rs6000/rs6000.md @@ -383,7 +383,7 @@ (const_int 1) (and (eq_attr "isa" "p6") - (match_test "TARGET_CMPB")) + (match_test "TARGET_POWER6")) (const_int 1) (and (eq_attr "isa" "p7") @@ -2544,7 +2544,7 @@ (define_insn "parity<mode>2_cmpb" [(set (match_operand:GPR 0 "gpc_reg_operand" "=r") (unspec:GPR [(match_operand:GPR 1 "gpc_reg_operand" "r")] UNSPEC_PARITY))] - "TARGET_CMPB" + "TARGET_POWER6" "prty<wd> %0,%1" [(set_attr "type" "popcnt")]) @@ -2597,7 +2597,7 @@ [(set (match_operand:GPR 0 "gpc_reg_operand" "=r") (unspec:GPR [(match_operand:GPR 1 "gpc_reg_operand" "r") (match_operand:GPR 2 "gpc_reg_operand" "r")] UNSPEC_CMPB))] - "TARGET_CMPB" + "TARGET_POWER6" "cmpb %0,%1,%2" [(set_attr "type" "cmp")]) @@ -5401,7 +5401,7 @@ && ((TARGET_PPC_GFXOPT && !HONOR_NANS (<MODE>mode) && !HONOR_SIGNED_ZEROS (<MODE>mode)) - || TARGET_CMPB + || TARGET_POWER6 || VECTOR_UNIT_VSX_P (<MODE>mode))" { /* Middle-end canonicalizes -fabs (x) to copysign (x, -1), @@ -5422,7 +5422,7 @@ if (!gpc_reg_operand (operands[2], <MODE>mode)) operands[2] = copy_to_mode_reg (<MODE>mode, operands[2]); - if (TARGET_CMPB || VECTOR_UNIT_VSX_P (<MODE>mode)) + if (TARGET_POWER6 || VECTOR_UNIT_VSX_P (<MODE>mode)) { emit_insn (gen_copysign<mode>3_fcpsgn (operands[0], operands[1], operands[2])); @@ -5438,7 +5438,7 @@ [(set (match_operand:SFDF 0 "gpc_reg_operand" "=d,wa") (copysign:SFDF (match_operand:SFDF 1 "gpc_reg_operand" "d,wa") (match_operand:SFDF 2 "gpc_reg_operand" "d,wa")))] - "TARGET_HARD_FLOAT && (TARGET_CMPB || VECTOR_UNIT_VSX_P (<MODE>mode))" + "TARGET_HARD_FLOAT && (TARGET_POWER6 || VECTOR_UNIT_VSX_P (<MODE>mode))" "@ fcpsgn %0,%2,%1 xscpsgndp %x0,%x2,%x1" @@ -10122,7 +10122,7 @@ (match_operand:BLK 2))) (use (match_operand:SI 3)) (use (match_operand:SI 4))])] - "TARGET_CMPB && (BYTES_BIG_ENDIAN || TARGET_LDBRX)" + "TARGET_POWER6 && (BYTES_BIG_ENDIAN || TARGET_LDBRX)" { if (optimize_insn_for_size_p ()) FAIL; @@ -10144,7 +10144,7 @@ (compare:SI (match_operand:BLK 1) (match_operand:BLK 2))) (use (match_operand:SI 3))])] - "TARGET_CMPB && (BYTES_BIG_ENDIAN || TARGET_LDBRX)" + "TARGET_POWER6 && (BYTES_BIG_ENDIAN || TARGET_LDBRX)" { if (optimize_insn_for_size_p ()) FAIL;