https://gcc.gnu.org/bugzilla/show_bug.cgi?id=124975

--- Comment #6 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to David Binderman from comment #0)
...snip...
> Maybe better code:
> 
>           if (remap->u.ar.start[dim]->expr_type != EXPR_CONSTANT
>               && remap->u.ar.start[dim]->expr_type != EXPR_VARIABLE)
>             gfc_resolve_expr (remap->u.ar.start[dim]);
>           if (remap->u.ar.end[dim]->expr_type != EXPR_CONSTANT
>               && remap->u.ar.end[dim]->expr_type != EXPR_VARIABLE)
>             gfc_resolve_expr (remap->u.ar.end[dim]);
> 
> git blame seems to think Paul Thomas wrote this code:

Mea maxima culpa. The proposed replacement is good. Fortunately, for scalar
integer expressions, unconditionally calling gfc_resolve_expr cannot do any
harm.

I will take care of it later this morning.

Paul

Reply via email to