https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125430

--- Comment #5 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 64580
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=64580&action=edit
Update of the fix to cover all types of private declaration

Hi Jerry,

The patch 0001-fortran-fix-two-bugs-in-module-procedure-ELF-linkage.patch
didn't just supersede
0001-fortran-module-contained-PRIVATE-procedures-must-hav.patch but applied on
top of it! Unfortunately, my editorial suggestions resulted in the new patch
not applying cleanly.

This attachment was applied "by hand" and adds to further tests to ensure that
the symbol being declared private and the use of -fmodule-private work as they
should. I haven't as yet changed the comments in the testcases. I am not sure
whether or not these new tests are a bit over the top....

I will leave it to you to update the comments on all three tests and to
generate the ChangeLog. Consider this to have been okayed for application to
mainline.

I would suggest fairly early backporting of these patches; (1) because we will
get earlier feedback on regressions and (ii) we are already losing track of
what is which :-)

Paul

Reply via email to