https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117851

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Jakub Jelinek
<ja...@gcc.gnu.org>:

https://gcc.gnu.org/g:326b6bac1f61302daf285e45baf39a6a30511272

commit r14-11149-g326b6bac1f61302daf285e45baf39a6a30511272
Author: Jakub Jelinek <ja...@redhat.com>
Date:   Sat Nov 30 11:19:12 2024 +0100

    openmp: Add crtoffloadtableS.o and use it [PR117851]

    Unlike crtoffload{begin,end}.o which just define some symbols at the
start/end
    of the various .gnu.offload* sections, crtoffloadtable.o contains
    const void *const __OFFLOAD_TABLE__[]
      __attribute__ ((__visibility__ ("hidden"))) =
    {
      &__offload_func_table, &__offload_funcs_end,
      &__offload_var_table, &__offload_vars_end,
      &__offload_ind_func_table, &__offload_ind_funcs_end,
    };
    The problem is that linking this into PIEs or shared libraries doesn't
    work when it is compiled without -fpic/-fpie - __OFFLOAD_TABLE__ for
non-PIC
    code is put into .rodata section, but it really needs relocations, so for
    PIC it should go into .data.rel.ro/.data.rel.ro.local.
    As I think we don't want .data.rel.ro section in non-PIE binaries, this
patch
    follows the path of e.g. crtbegin.o vs. crtbeginS.o and adds
crtoffloadtableS.o
    next to crtoffloadtable.o, where crtoffloadtableS.o is compiled with -fpic.

    2024-11-30  Jakub Jelinek  <ja...@redhat.com>

            PR libgomp/117851
    gcc/
            * lto-wrapper.cc (find_crtoffloadtable): Add PIE_OR_SHARED
argument,
            search for crtoffloadtableS.o rather than crtoffloadtable.o if
            true.
            (run_gcc): Add pie_or_shared variable.  If OPT_pie or OPT_shared or
            OPT_static_pie is seen, set pie_or_shared to true, if OPT_no_pie is
            seen, set pie_or_shared to false.  Pass it to find_crtoffloadtable.
    libgcc/
            * configure.ac (extra_parts): Add crtoffloadtableS.o.
            * Makefile.in (crtoffloadtableS$(objext)): New goal.
            * configure: Regenerated.

    (cherry picked from commit f089ef880e385e2193237b1f53ec81dac4141680)
  • [Bug libgomp/117851] all amdgcn... cvs-commit at gcc dot gnu.org via Gcc-bugs

Reply via email to