https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81358

--- Comment #29 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot 
Uni-Bielefeld.DE> ---
> --- Comment #22 from prathamesh3492 at gcc dot gnu.org ---

> @all: Could you please test it on your machines, and let me know if it causes
> any further issues ? I plan to commit it in next 2-3 days if no further issues
> prop up. Thanks!

I've now bootstrapped the patch on i386-pc-solaris2.11 (and
x86_64-pc-linux-gnu for comparison's sake, still running).  The good
news is that this version no longer breaks Solaris bootstrap.  However,
it has one fundamental problem: on anything but Linux, -flink-libatomic
is a no-op: LINK_LIBATOMIC_SPEC is only used in gcc/config/gnu-user.h
while the docs suggest this is a generic option.  I don't think this is
acceptable.

Besides, I noticed two nits:

* After a full stop, there should be two blanks, not one (seen in
  gcc/doc/invoke.texi and libatomic/configure.ac).

* Similarly, the description in gcc/configure.ac (AC_DEFINE) should end
  in a full stop.

Reply via email to