[Bug tree-optimization/116643] PHI_RESULT vs gimple_phi_result/gimple_phi_result_ptr

[pinskia at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116643

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---

here is a few more that should/can be changed:
```
#define USE_FROM_PTR(PTR)       get_use_from_ptr (PTR)
#define DEF_FROM_PTR(PTR)       get_def_from_ptr (PTR)
#define SET_USE(USE, V)         set_ssa_use_from_ptr (USE, V)
#define PHI_ARG_DEF_PTR(PHI, I) gimple_phi_arg_imm_use_ptr ((PHI), (I))
#define PHI_ARG_DEF(PHI, I)     gimple_phi_arg_def ((PHI), (I))

#define PHI_ARG_DEF_FROM_EDGE(PHI, E)                                   \
                                gimple_phi_arg_def_from_edge ((PHI), (E))
#define PHI_ARG_DEF_PTR_FROM_EDGE(PHI, E)                               \
                                gimple_phi_arg_imm_use_ptr_from_edge ((PHI),
(E))
#define PHI_ARG_INDEX_FROM_USE(USE)   phi_arg_index_from_use (USE)

```

One more thing is I noticed we do:
gimple_phi_arg_def (phi, e2->dest_idx)

All the time, when maybe we should just do:
gimple_phi_arg_def_from_edge (phi, e2)