https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114065

--- Comment #29 from Arnaud Charlet <charlet at gcc dot gnu.org> ---
Hi Nicolas,
Reviewing v10 (and v11), I have the following comments left:
For patch 1/8, the change in a-calcon.ads is still too intrusive (incompatible
types used), we want to keep the interface (spec) unchanged, and perform any
needed conversion in the body before calling System.C_Time.xxx, otherwise this
defeats the purpose of keeping these functions in the first place.

In s-c_time.adb, please fix the indentation in In_Duration:

  return Dur_Covers_Tv_Sec
    or else  T.tv_sec < Maybe_Sec
    or else (T.tv_sec = Maybe_Sec and then T.tv_usec <= Usec);

We're testing the patches internally at AdaCore to confirm that there are no
unforeseen issue on this delicate patch, but looks like we are converging,
thank you for your patience here !

Reply via email to