https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368

--- Comment #8 from paul.richard.thomas at gmail dot com <paul.richard.thomas 
at gmail dot com> ---
Hi Harald,

I simply copied all the associated functions in trans-expr.cc from mainline
and plonked them in 13-branch. That's why I said that I hadn't done any
weeding. There is also a commit from Jakub in there as well. I'll check to
see if the associated PRs are fixed.

I got into regression fixing before the 14.1 release and this was one of
the low hanging fruit. To be honest, I am not especially bothered about
fixing it or not. Up until the ICE of the PR it was giving an error on
valid code. I would prefer though that the ICE went away!

Cheers

Paul





On Thu, 23 May 2024 at 19:18, anlauf at gcc dot gnu.org <
gcc-bugzi...@gcc.gnu.org> wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
>
> anlauf at gcc dot gnu.org changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |anlauf at gcc dot gnu.org
>
> --- Comment #7 from anlauf at gcc dot gnu.org ---
> (In reply to Paul Thomas from comment #6)
> > Created attachment 58277 [details]
> > Fix for this PR
> >
> > This was substantially fixed on 14-branch by the patch for PR49213.
> However,
> > there have been many subsequent changes to gfc_trans_structure_assign and
> > its subsidiary functions as the attachment demonstrates.
> >
> > I haven't attempted to do any weeding of the changes to separate those
> > responsible for fixing this PR. However, 13-branch regtests successfuly
> with
> > the patch applied.
> >
> > Should I commit this with a testcase or just close the PR?
> >
> > Paul
>
> Paul,
>
> can you summarize where you gathered the pieces of this patch from?
>
> From a quick glance, r14-870 and r14-2160 (both yours) seem to be involved.
>
> Does it also fix any of the issues addressed by the respective PRs?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You are the assignee for the bug.

Reply via email to