https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102989

--- Comment #115 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 56482
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56482&action=edit
modula2: proposed fix to fix largeconst.mod

Here is a patch set for the modula2 fe which re-implements the ZTYPE overflow
detection.

Bootstrapped on x86_64 all regressions pass.

The ZTYPE in iso modula2 is used to denote intemediate ordinal type const
expressions and these are always converted into the
approriate language or user ordinal type prior to code generation.
The increase of bits supported by _BitInt causes the modula2 largeconst.mod
regression failure tests to pass.  The largeconst.mod test has been
increased to fail, however the char at a time overflow check is now too slow
to detect failure.  The overflow detection for the ZTYPE has been
rewritten to check against exceeding WIDE_INT_MAX_PRECISION (many orders of
magnitude faster).

gcc/m2/ChangeLog:

        * gm2-compiler/SymbolTable.mod (OverflowZType): Import from m2expr.
        (ConstantStringExceedsZType): Remove import.
        (GetConstLitType): Replace ConstantStringExceedsZType with
OverflowZType.
        * gm2-gcc/m2decl.cc (m2decl_ConstantStringExceedsZType): Remove.
        (m2decl_BuildConstLiteralNumber): Re-write.
        * gm2-gcc/m2decl.def (ConstantStringExceedsZType): Remove.
        * gm2-gcc/m2decl.h (m2decl_ConstantStringExceedsZType): Remove.
        * gm2-gcc/m2expr.cc (m2expr_StrToWideInt): Rewrite to check overflow.
        (m2expr_OverflowZType): New function.
        (ToWideInt): New function.
        * gm2-gcc/m2expr.def (OverflowZType): New procedure function
declaration.
        * gm2-gcc/m2expr.h (m2expr_OverflowZType): New prototype.

gcc/testsuite/ChangeLog:

        * gm2/pim/fail/largeconst.mod: Updated foo to an outrageous value.
        * gm2/pim/fail/largeconst2.mod: Duplicate test removed.
  • [Bug c/102989] Implement C2x's ... gaius at gcc dot gnu.org via Gcc-bugs

Reply via email to