https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111413

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <ja...@gcc.gnu.org>:

https://gcc.gnu.org/g:15345980633c502f0486a2e40e96224f49134130

commit r14-4122-g15345980633c502f0486a2e40e96224f49134130
Author: Jakub Jelinek <ja...@redhat.com>
Date:   Tue Sep 19 09:26:35 2023 +0200

    libgomp: Handle NULL environ like pointer to NULL pointer [PR111413]

    clearenv function just sets environ to NULL (after sometimes freeing it),
    rather than setting it to a pointer to NULL, and our code was assuming
    it is always non-NULL.

    Fixed thusly, the change seems to be large but actually is just
    +  if (environ)
         for (env = environ; *env != 0; env++)
    plus reindentation.  I've also noticed the block after this for loop
    was badly indented (too much) and fixed that too.

    No testcase added, as it needs clearenv + dlopen.

    2023-09-19  Jakub Jelinek  <ja...@redhat.com>

            PR libgomp/111413
            * env.c (initialize_env): Don't dereference environ if it is NULL.
            Reindent.

Reply via email to