https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110875
Andrew Macleod <amacleod at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Andrew Macleod <amacleod at redhat dot com> ---
When range_of_stmt invokes prefill_name to evaluate unvisited dependencies it
should not mark visited names as always_current.
when ranger_cache::get_globaL_range() is invoked with the optional "current_p"
flag, it triggers additional functionality. This call is meant to be from
within ranger and it is understood that if the current value is not current,
set_global_range will always be called later with a value. Thus it sets the
always_current flag in the temporal cache to avoid computation cycles.
the prefill_stmt_dependencies () mechanism within ranger is intended to emulate
the bahaviour of range_of_stmt on an arbitrarily long series of unresolved
dependencies without triggering the overhead of huge call chains from the
range_of_expr/range_on_entry/range_on_exit routines. Rather, it creates a
stack of unvisited names, and invokes range_of_stmt on them directly in order
to get initial cache values for each ssa-name.
The issue in this PR was that routine was incorrectly invoking the
get_global_cache to determine whether there was a global value. If there was,
it would move on to the next dependency without invoking set_global_range to
clear the always_current flag.
What it should have been doing was simply checking if there as a global value,
and if there was not, add the name for processing and THEN invoke
get_global_value to do all the special processing.
fixed.
