https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54089
--- Comment #101 from Oleg Endo <olegendo at gcc dot gnu.org> --- (In reply to Alexander Klepikov from comment #100) > Created attachment 55513 [details] > Arithmetic right shift late expanding > > (In reply to Oleg Endo from comment #99) > > Meanwhile, here's my iteration on your patch. > > Thank you! I did all checks I did before, added testcases, and edited to fit > the code style. Looks OK. Just 3 things: > +++ gcc-13.1.0/gcc/testsuite/gcc.target/sh/pr54089-11.c 2023-07-07 > 08:56:41.212345982 +0300 > @@ -0,0 +1,37 @@ > +/* Check that 'tst #64,r0' genrated. */ > +/* { dg-do compile } */ > +/* { dg-options "-O2" } */ Please rename this test to pr49263... to have all tst #imm,r0 related tests in one place. Also: - 'genrated' -> 'generated' - space before opening paren of function args - 2 spaces indention - similarly, check code style of other added tests > --- gcc-13.1.0.orig/gcc/testsuite/gcc.target/sh/pr54089-12.c 1970-01-01 > 03:00:00.000000000 +0300 Can you try out Segher's suggestion in #c88 to make the regex look less cluttered?