https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108674

--- Comment #12 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Roman Lebedev from comment #10)
> I'm not at all familiar with the GCC's preferred patch protocol,

See https://gcc.gnu.org/contribute.html#patches

> this is the result of `git format-patch origin/master`,

That format is great.

> with commit message mimicking the ones of the recent commits.
> Please let me know what i got wrong this time.

The commit message should be in the form "libstdc++: ..."

I would just use "libstdc++: silence clang's Integer Sanitizer [PR108674]".

The no_sanitize attribute needs to be __no_sanitize__ instead, because this is
a valid program:

#define no_sanitize !!1!1
#include <string>
int main() { }


Otherwise this looks reasonable. The
__no_sanitize__("unsigned-integer-overflow") attribute seems to be supported by
all non-ancient versions of Clang.

Also, please note that the Signed-off-by: tag has the meaning described at
https://gcc.gnu.org/dco.html so please be sure that's what you intend when
using it :-)

Please make the changes above and post to the gcc-patches list, CCing the
libstdc++ list, thanks!

Reply via email to