https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104859
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |ppalka at gcc dot
gnu.org
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2022-03-09
--- Comment #5 from Patrick Palka <ppalka at gcc dot gnu.org> ---
I think we just need to add some explicit casts:
diff --git a/libstdc++-v3/src/c++17/floating_to_chars.cc
b/libstdc++-v3/src/c++17/floating_to_chars.cc
index 5825e661bf4..0ccf2623511 100644
--- a/libstdc++-v3/src/c++17/floating_to_chars.cc
+++ b/libstdc++-v3/src/c++17/floating_to_chars.cc
@@ -801,14 +801,14 @@ template<typename T>
char leading_hexit;
if constexpr (has_implicit_leading_bit)
{
- const unsigned nibble = effective_mantissa >> rounded_mantissa_bits;
+ const unsigned nibble = unsigned(effective_mantissa >>
rounded_mantissa_bits);
__glibcxx_assert(nibble <= 2);
leading_hexit = '0' + nibble;
effective_mantissa &= ~(mantissa_t{0b11} << rounded_mantissa_bits);
}
else
{
- const unsigned nibble = effective_mantissa >>
(rounded_mantissa_bits-4);
+ const unsigned nibble = unsigned(effective_mantissa >>
(rounded_mantissa_bits-4));
__glibcxx_assert(nibble < 16);
leading_hexit = "0123456789abcdef"[nibble];
effective_mantissa &= ~(mantissa_t{0b1111} <<
(rounded_mantissa_bits-4));
@@ -853,7 +853,7 @@ template<typename T>
while (effective_mantissa != 0)
{
nibble_offset -= 4;
- const unsigned nibble = effective_mantissa >> nibble_offset;
+ const unsigned nibble = unsigned(effective_mantissa >>
nibble_offset);
__glibcxx_assert(nibble < 16);
*first++ = "0123456789abcdef"[nibble];
++written_hexits;
since on targets which lack __int128, effective_mantissa can be the
integer-class uint128_t, which unlike __int128 is only _explicitly_ convertible
to the builtin integer types. And r12-7563-ge32869a17b788b made us correctly
exclude explicit conversion operators during copy-initialization.
