https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102144
Bug ID: 102144
Summary: hwsan has a hardcoded pagesize requirement for aarch64
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: sanitizer
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at
gcc dot gnu.org
Target Milestone: ---
Target: aarch64-linux-gnu
I am using Linux 5.4.74 and the hwasan testcases have never passed for me on
OcteonTX 2 96xx which is an ARMv8.2-a processor by Marvell. I am using glibc
2.27. ****With 64k pages.******
Almost all fail the same way:
==3382612==ERROR: HWAddressSanitizer failed to deallocate 0x4000 (16384) bytes
at address 0xfffff68a2000
HWAddressSanitizer: CHECK failed: sanitizer_posix.cpp:61 "(("unable to unmap"
&& 0)) != (0)" (0x0, 0x0) (tid=3382612)
#0 0xfffff764ceb8 in CheckUnwind gcc/libsanitizer/hwasan/hwasan.cpp:137
#1 0xfffff766cac0 in __sanitizer::CheckFailed(char const*, int, char
const*, unsigned long long, unsigned long long)
gcc/libsanitizer/sanitizer_common/sanitizer_termination.cpp:86
#2 0xfffff7660418 in __sanitizer::UnmapOrDie(void*, unsigned long)
gcc/libsanitizer/sanitizer_common/sanitizer_posix.cpp:61
#3 0xfffff7660418 in __sanitizer::UnmapOrDie(void*, unsigned long)
gcc/libsanitizer/sanitizer_common/sanitizer_posix.cpp:55
#4 0xfffff7661188 in __sanitizer::MmapAlignedOrDieOnFatalError(unsigned
long, unsigned long, char const*)
gcc/libsanitizer/sanitizer_common/sanitizer_posix.cpp:99
#5 0xfffff7653464 in
__hwasan::SavedStackAllocations::SavedStackAllocations(__sanitizer::CompactRingBuffer<unsigned
long>*) gcc/libsanitizer/hwasan/hwasan_report.cpp:113
#6 0xfffff7653464 in __hwasan::ReportTagMismatch(__sanitizer::StackTrace*,
unsigned long, unsigned long, bool, bool, unsigned long*)
gcc/libsanitizer/hwasan/hwasan_report.cpp:647
#7 0xfffff764d188 in __hwasan::HandleTagMismatch(__hwasan::AccessInfo,
unsigned long, unsigned long, void*, unsigned long*)
gcc/libsanitizer/hwasan/hwasan.cpp:215
#8 0xfffff764f8e4 in HwasanOnSIGTRAP
gcc/libsanitizer/hwasan/hwasan_linux.cpp:379
#9 0xfffff764f8e4 in __hwasan::HwasanOnDeadlySignal(int, void*, void*)
gcc/libsanitizer/hwasan/hwasan_linux.cpp:399
#10 0xfffff7fc05e0 (linux-vdso.so.1+0x5e0)
#11 0xfffff764da58 in __hwasan_load4 gcc/libsanitizer/hwasan/hwasan.cpp:442
#12 0x400b54 in main c-c++-common/hwasan/large-aligned-untagging-0.c:64
#13 0xfffff71e06dc in __libc_start_main
(/lib/aarch64-linux-gnu/libc.so.6+0x206dc)
#14 0x400bdc
(/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/gcc/testsuite/g++1/large-aligned-untagging-7.exe+0x400bdc)
Here is part of kernel config which might make a difference:
CONFIG_ARM64_PAGE_SHIFT=16
CONFIG_ARM64_CONT_SHIFT=5
CONFIG_ARCH_MMAP_RND_BITS_MIN=14
CONFIG_ARCH_MMAP_RND_BITS_MAX=29
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MIN=7
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MAX=16
...
CONFIG_ARM64_64K_PAGES=y
CONFIG_ARM64_VA_BITS_48=y
CONFIG_ARM64_VA_BITS=48
CONFIG_ARM64_PA_BITS_48=y
CONFIG_ARM64_PA_BITS=48
CONFIG_ARM64_TAGGED_ADDR_ABI=y
CONFIG_ARM64_HW_AFDBM=y
CONFIG_ARM64_PAN=y
CONFIG_ARM64_LSE_ATOMICS=y
CONFIG_ARM64_VHE=y
CONFIG_ARM64_RAS_EXTN=y
CONFIG_ARM64_CNP=y
# git grep 4096
hwasan/hwasan.cpp: cf.clear_shadow_mmap_threshold = 4096 *
(SANITIZER_ANDROID ? 2 : 8);
hwasan/hwasan.cpp:static constexpr uptr kMemoryUsageBufferSize = 4096;
hwasan/hwasan_thread_list.h:// * Each ring buffer has a size of (2**N)*4096
where N is in [0, 8), and is
hwasan/hwasan_thread_list.h: uptr size = 4096 * (1ULL << shift);
The important one here is one in hwasan/hwasan_thread_list.h.
I will see tomorrow if changing it to be based on the current page size will
fix the problem I am seeing.
