https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96063
Martin Sebor <msebor at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #11 from Martin Sebor <msebor at gcc dot gnu.org> --- Checking the return value is good -- it's also what I did in the patch I submitted yesterday: https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549476.html (I had overlooked your patch in comment #8.) What I was saying is that taking the value of a warn_xxx variable as an indication of thew result of a warning() call is wrong because the former doesn't reflect all the machinations the warning() call goes through to decide whether or not to issue a warning.